Skip to content

fix(auth): include retry interval in pending device authorization error - #264

Closed
jskorlol wants to merge 1 commit into
icoretech:mainfrom
jskorlol:fix/include-retry-interval-in-pending-device-authorization-error
Closed

fix(auth): include retry interval in pending device authorization error#264
jskorlol wants to merge 1 commit into
icoretech:mainfrom
jskorlol:fix/include-retry-interval-in-pending-device-authorization-error

Conversation

@jskorlol

@jskorlol jskorlol commented Aug 6, 2026

Copy link
Copy Markdown
Contributor
image

This is a PR regarding the resolution of the issue. #188

  1. Fixed device link issue (disconnecting within 5 seconds)
  2. Added copy button

@jskorlol

jskorlol commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

@masterkain Please check this just this once.

masterkain added a commit that referenced this pull request Aug 13, 2026
OpenAI generic 403/404 device responses omitted the configured retry interval, so nested authorization_pending replies were finalized as token-exchange failures instead of scheduling another poll.

Preserve the interval and give operators consistent copy actions for authorization URLs, device codes, and verification URLs across link and relink surfaces. Keep copied feedback stable during LiveView polling patches.

refs #264

refs #188

Co-authored-by: jskorlol <jskorlol@gmail.com>
@masterkain

Copy link
Copy Markdown
Member

Thanks @jskorlol for the detailed diagnosis and proposed fix in PR #264

We independently reproduced the failure reported in issue #188: generic device-token 403/404 pending responses lacked retry_after_seconds, so the persisted flow treated a retryable response as a terminal token-exchange failure

What shipped on main:

The retained findings landed independently in commit 6748fde7, rather than by merging or cherry-picking this branch. Attribution for the finding remains with you, and the landing commit preserves your co-authorship

Verification completed:

  • focused Codex auth tests: 15 passed
  • mix quality: passed
  • the running LiveView was exercised through pending polling, copied-feedback persistence, fresh-flow replacement, cancellation, and mobile layout

The full suite was intentionally not rerun for the final test-only amendment

Closing PR #264 without merging because the confirmed work is now on main; nothing from its verified scope is deliberately left open

@masterkain masterkain closed this Aug 13, 2026
@jskorlol
jskorlol deleted the fix/include-retry-interval-in-pending-device-authorization-error branch August 13, 2026 07:31
masterkain added a commit that referenced this pull request Aug 13, 2026
The pending browser flow looked like a completed success and hid the cross-browser copy action behind an unlabeled icon, which made the operator handoff difficult to follow.

Use one compact two-step workflow for link and relink, keep pending status neutral, expose a labeled copy action, and provide a deterministic dev showcase for visual review.

refs #264

refs #188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants